remove generic from parsable factory type hint error#796
Merged
shemogumbe merged 1 commit intomainfrom Jan 9, 2025
Merged
Conversation
|
baywet
requested changes
Jan 8, 2025
Ndiritu
approved these changes
Jan 9, 2025
baywet
approved these changes
Jan 9, 2025
Member
|
@shemogumbe please make sure you use conventional commit (fix: or feat: prefix) whenever merging/committing to trigger the releases and build the changelog! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #781
Demo
Running
python from msgraph_core import APIVersion, GraphClientFactoryBefore the changes
Traceback (most recent call last): File "C:\Users\shemogumbe\kiota-python\msgraph-sdk-python-core\src\app_test_lfu_changes.py", line 1, in <module> from msgraph_core import APIVersion, GraphClientFactory File "C:\Users\shemogumbe\kiota-python\msgraph-sdk-python-core\src\msgraph_core\__init__.py", line 16, in <module> from .tasks import PageIterator File "C:\Users\shemogumbe\kiota-python\msgraph-sdk-python-core\src\msgraph_core\tasks\__init__.py", line 2, in <module> from .large_file_upload import LargeFileUploadTask File "C:\Users\shemogumbe\kiota-python\msgraph-sdk-python-core\src\msgraph_core\tasks\large_file_upload.py", line 21, in <module> class LargeFileUploadTask: File "C:\Users\shemogumbe\kiota-python\msgraph-sdk-python-core\src\msgraph_core\tasks\large_file_upload.py", line 28, in LargeFileUploadTask parsable_factory: Optional[ParsableFactory[T]] = None, TypeError: 'ABCMeta' object is not subscriptableAfter the changes - No error